-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Claude/fix dashbrew auth a qw4 p #1162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pedrobando
wants to merge
30
commits into
gitroomhq:main
Choose a base branch
from
pedrobando:claude/fix-dashbrew-auth-AQw4P
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Claude/fix dashbrew auth a qw4 p #1162
pedrobando
wants to merge
30
commits into
gitroomhq:main
from
pedrobando:claude/fix-dashbrew-auth-AQw4P
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… explicit image tag
- Updated settings page to accept provider and code query parameters - Added OAuth flow initiation when provider=GENERIC is detected - Implemented authorization code exchange for existing users - Added redirect logic for new user registration flow - Fixed infinite loading spinner issue during SSO login from DashBrew - Added proper error handling and user feedback for OAuth failures This enables seamless SSO authentication from DashBrew to Postiz.
- Added toast to initiateOAuthFlow dependencies - Added toast to handleOAuthCallback dependencies - Fixes build error during deployment
- Moved useEffect after callback definitions - Added eslint-disable comment for exhaustive-deps - Fixes 'React Hook used before definition' build error
Testing if build failure is caused by OAuth implementation or pre-existing issue
- Changed OAuth redirect_uri from /settings to /auth?provider=generic - The /auth page already has OAuth callback handling in register.tsx - Added handling for existing users (login=true) to redirect to dashboard - New users still see the registration form to enter company name This fixes the 404 error when trying to login/register with Dashbrew OAuth.
- Added POST /auth/token endpoint to validate JWT tokens from external SSO - Added validateAndRefreshToken method to auth service - Updated register.tsx to handle 'token' URL parameter for SSO callbacks - This enables login from Dashbrew which sends JWT tokens directly When logging in from Dashbrew, users are redirected with a JWT token in the URL. The frontend now detects this, validates the token via the new endpoint, and redirects to the dashboard.
- Restored OAuth SSO handling in settings.component.tsx - Settings page now properly handles /settings?provider=GENERIC flow - When provider param is present, initiates OAuth authorization flow - When code param is present, exchanges code for token - Fixed GitHub Actions hashFiles timeout by simplifying cache key (removed **/*.js pattern that was scanning node_modules) This enables the full OAuth flow when DashBrew redirects to: https://social.dashbrew.app/settings?provider=GENERIC
|
@claude is attempting to deploy a commit to the Listinai Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.